Okay, here's my third pass. Re Tim's comments -- 1) -optional. I have put it back in, although don't know that we need to be bending over to support people whose last line is "from * drop." :0
3a) calling lower() in FlatFileStore -- I'm not conviced this is needed. We don't lower() every key read from the DB formats, and there's nothing stopping people from modifying those manually, either. We already lower() both on append to flat files and on creation of an autodb from flat files, if anything; there's too much lower()ing going on already. Better to have it well-defined at which points we can assume lower() has been done already, to avoid redundancy. I suggest we leave the lower() on append in, and remove the others. I suppose if you disagree it's pretty trivial to put a lower() in FlatFileStore.__init__ like you said. :) 3b) put dbmstore code back in, with less "magic" strings getting passed around. commented so the next guy to come along won't make the same mistake. :) the autobuild functionality is now in an superclass of cdbstore and dbmstore. -Jonathan
jbe-diff.tar.gz
Description: GNU Zip compressed data
