Jim Ramsay <[EMAIL PROTECTED]> writes: > When you click the "Whitelist" button in tmda-cgi, it simply calls > MsgObj.whitelist() (The whitelist method from class Message in > TMDA/Pending.py) Whereas releasing a message by confirmation email > does a completely different thing in tmda-rfilter. Also, releasing it > by URL confirmation would probably work fine, as this approximates the > same code in tmda-rfilter. This same problem would have come up > sooner if anyone still used the good old 'tmda-pending' program or > PENDING_RELEASE_APPEND. > > So, what could the issue in TMDA/Pending.py be? It looks like the > "initMessage" routine in the Message class completely ignores > x-primary-address. > > For a fix, I propose:
OK Jim, you were right afterall; ignore my last two messages in this thread. Tim and I figured this out after an hour or so of bantering tonight on AIM. What threw me the curve-ball was that I didn't realize that a tmda-cgi "whitelist" also triggers a "release" -- this isn't the same behavior as in tmda-pending. So, I assumed Jeff meant he was seeing the wrong address appended when he confirmed a message, when he was really just whitelisting the message. Grr... Anyway, your fix has the right spirit, but I'm going to work on a slightly different implementation this weekend. What I need to do is change all the appends to PENDING_*_APPEND files in Pending.py to honor X-Primary-Address instead of just always using the Return-Path address. This should fix Jeff's problem, and it also the correct behavior I think. _________________________________________________ tmda-workers mailing list ([EMAIL PROTECTED]) http://tmda.net/lists/listinfo/tmda-workers
