-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert P. Thille wrote:
> 
> Hi Everyone,
> 
> I finally got around to setting up tmda-ofmipd and upgrading to 1.1.8
> ...
> 
> I added the patch to catch the exceptions around
> self.__server.process_message(), and noticed that the server would then
> emit my error message (451), then a '250 ok'.  I think the error
> handling for 'Outgoing mail quota exceeded' was wrong as well, so I
> cleaned that up.

Robert,

Sorry for sitting on this patch for so long - I've evidently been
distracted!

I had one question about the exception handler code you added as
described above. Specifically, do you have any way of easily reproducing
the exceptions that your code catches. A long time ago, I wrote the
original code for that exception handler that you included, but I can't
work out how to trigger the problem I was trying to solve originally -
any information would be greatly appreciated!

> While I was at it, I added the '-l' (ell) option that someone else
> talked about for intermediate logging between nothing (the default)
> and -d.  Basically, it logs everything that -d does, except the data
> coming from the client (so I don't have to worry about logging whole
> messages or passwords).

The only issue I have with this is is that "-l" (letter) looks a lot
like the new "-1" (number) option I recently added. I'd guess that
making it capitals ("-L" ) would be enough to remove this distraction.

Sorry, I didn't have a chance to review the other parts of the patch
fully yet. I really hope to get around to this soon though!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFVVkLhk3bo0lNTrURAgYHAKCkU2/YDlWLtPQIYP2WiiCxK1sxeACeP5LC
8JxArBJ+eNDNT+NKrDkHpK8=
=/8Zq
-----END PGP SIGNATURE-----
_________________________________________________
tmda-workers mailing list ([email protected])
http://tmda.net/lists/listinfo/tmda-workers

Reply via email to