Branch: refs/heads/4902-image-support
Home: https://github.com/tmux/tmux
Commit: 67f671b345f130b791877fae317379ff05ec107b
https://github.com/tmux/tmux/commit/67f671b345f130b791877fae317379ff05ec107b
Author: Michael Grant <[email protected]>
Date: 2026-08-22 (Sat, 22 Aug 2026)
Changed paths:
M image.c
A regress/image-scroll-off-recovery.sh
Log Message:
-----------
image: keep the scrolled-off portion of a placement instead of discarding it
image_write() handles an image taller than the pane by scrolling the
screen up to make room, but only ever created spans for the rows that
ended up on screen afterwards - the rows immediately scrolled off (up to
origin_y of them) were pushed into history as blank, spanless rows and
that part of the image was permanently discarded. Unlike width, which has
no "scroll right" to recover a permanent clip, height already has
ordinary scrollback, so this was pure waste: scrolling back up just
showed empty space where part of the image used to be.
image_write() now also calls image_extend_row() for those origin_y rows,
capped to however many real history rows screen_write_scrollup() actually
created (it clamps its own request to one scroll-region height per call,
so a single call may not push everywhere origin_y implies - looping it
until the full amount is pushed, done here too, makes that gap rare, but
the cap keeps the fill-in safe even if it isn't).
To unsubscribe from these emails, change your notification settings at
https://github.com/tmux/tmux/settings/notifications
--
You received this message because you are subscribed to the Google Groups
"tmux-git" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion, visit
https://groups.google.com/d/msgid/tmux-git/tmux/tmux/push/refs/heads/4902-image-support/cfd178-67f671%40github.com.
