Could you resend your entire patch please? I haven't had time to look at
it yet and when I do it'd be easier if I have the whole thing in one
email.

Thanks


On Tue, Dec 31, 2013 at 08:31:44AM -0800, Suraj Kurapati wrote:
> Hello,
> 
> Hello,
> 
> There was a bug in my original patch where `tmux select-pane` would
> segfault if the current window had only 1 pane.
> 
> The following changes fix that bug:
> 
> diff --git a/window.c b/window.c
> index 7412a4d..adb67e0 100644
> --- a/window.c
> +++ b/window.c
> @@ -1163,9 +1163,10 @@ window_pane_refocus(struct window_pane *wp,
> struct window_pane *wp2)
>                 if (lc == wp2->layout_cell->parent)
>                         return (wp2);
> 
> -       /* transfer would halt if focused pane was same as source pane */
> -       fp = wp2->layout_cell->parent->wp;
> -       if (fp != wp && fp != NULL && window_pane_visible(fp))
> +       /* focused pane, if any, must not be the same as source pane */
> +       lc = wp2->layout_cell->parent;
> +       fp = lc != NULL ? lc->wp : NULL;
> +       if (fp != NULL && fp != wp && window_pane_visible(fp))
>                 return (fp);
>         else
>                 return (wp2);
> 
> I am attaching a revised version (containing the above fix) of my
> original patch.
> 
> Thanks for your consideration.


> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT 
> organizations don't have a clear picture of how application performance 
> affects their revenue. With AppDynamics, you get 100% visibility into your 
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk

> _______________________________________________
> tmux-users mailing list
> tmux-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tmux-users


------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users

Reply via email to