On Mon, Oct 30, 2023 at 12:51 PM Alassane Yattara < [email protected]> wrote:
> Signed-off-by: Alassane Yattara <[email protected]> > --- > lib/toaster/orm/models.py | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/lib/toaster/orm/models.py b/lib/toaster/orm/models.py > index 0d503a51..4f6d2147 100644 > --- a/lib/toaster/orm/models.py > +++ b/lib/toaster/orm/models.py > @@ -1389,9 +1389,6 @@ class Machine(models.Model): > return "Machine " + self.name + "(" + self.description + ")" > > > - > - > - > class BitbakeVersion(models.Model): > > name = models.CharField(max_length=32, unique = True) > @@ -1838,6 +1835,7 @@ class LogMessage(models.Model): > def __str__(self): > return force_bytes('%s %s %s' % (self.get_level_display(), > self.message, self.build)) > > + > Why the extra new lines? Is this a PEP-8 thing? > def invalidate_cache(**kwargs): > from django.core.cache import cache > try: > @@ -1845,6 +1843,7 @@ def invalidate_cache(**kwargs): > except Exception as e: > logger.warning("Problem with cache backend: Failed to clear cache: > %s" % e) > > + > def signal_runbuilds(): > """Send SIGUSR1 to runbuilds process""" > try: > @@ -1853,6 +1852,9 @@ def signal_runbuilds(): > os.kill(int(pidf.read()), SIGUSR1) > except FileNotFoundError: > logger.info("Stopping existing runbuilds: no current process > found") > + except ProcessLookupError: > We should at a minimum be doing a logger.warning here. ProcessLookupError here most likely means that a subprocess has failed or been killed and we should not just be ignoring that. > + pass > + > > class Distro(models.Model): > search_allowed_fields = ["name", "description", > "layer_version__layer__name"] > -- > 2.34.1 > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#5917): https://lists.yoctoproject.org/g/toaster/message/5917 Mute This Topic: https://lists.yoctoproject.org/mt/102298001/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/toaster/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
