On Mon, Oct 30, 2023 at 12:51 PM Alassane Yattara < [email protected]> wrote:
> Pytest failed on functional/test_functional_basic because database access > not allowed > - we should use "django_db" fixture to allowed db access > > Note: Pytest-django takes a conservative approach to enabling database > access. > By default your tests will fail if they try to access the database. > Only if you explicitly request database access will this be allowed. > > We're missing an opportunity to add a link to pytest.mark.django_db documentation: https://pytest-django.readthedocs.io/en/latest/helpers.html#pytest-mark-django-db-request-database-access This makes it easier for someone to review the change and for someone in the future to understand what it does. Signed-off-by: Alassane Yattara <[email protected]> > --- > lib/toaster/tests/functional/test_functional_basic.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/toaster/tests/functional/test_functional_basic.py > b/lib/toaster/tests/functional/test_functional_basic.py > index b0def544..7e9be91c 100644 > --- a/lib/toaster/tests/functional/test_functional_basic.py > +++ b/lib/toaster/tests/functional/test_functional_basic.py > @@ -8,6 +8,7 @@ > # > > import re, time > +import pytest > from django.urls import reverse > from tests.functional.functional_helpers import SeleniumFunctionalTestCase > from orm.models import Project > @@ -16,6 +17,7 @@ from selenium.webdriver.common.by import By > class FuntionalTestBasic(SeleniumFunctionalTestCase): > > # testcase (1514) > + @pytest.mark.django_db > def test_create_slenium_project(self): > This would be a great opportunity to fix the typo in the test name slenium -> selenium > project_name = 'selenium-project' > self.get(reverse('newproject')) > -- > 2.34.1 > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#5918): https://lists.yoctoproject.org/g/toaster/message/5918 Mute This Topic: https://lists.yoctoproject.org/mt/102298278/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/toaster/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
