On 05/12/2013 15:27, "Paul Eggleton" <[email protected]> wrote:
>Hi Alex, > >On Tuesday 26 November 2013 18:28:21 Damian, Alexandru wrote: >> I have a set of patches for review on: >> >> >>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=toaster/mas >>ter > >Sorry for the delay (although we've had some changes in the mean time >with the >pkgdata changes). Reviewing the latest branch, most of the changes look >OK, >however I did notice the following: > >> bitbake: toasterui: record recipe licensing information > >If do_populate_lic doesn't execute in this build we won't have the >license file >with this method, right? Is that going to be a problem? That would explain this bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=5629 I am inclined to think it is a problem. > >> bitbake: toaster: update to Django 1.5.4 > >I think if we do do this we need to provide people with instructions on >how to >use virtualenv to install 1.5.4 on their system. I'm also a bit concerned >about us requiring one specific minor release because a number of distros >are >using 1.5 versions other than 1.5.4 - there shouldn't be any incompatible >changes introduced in minor releases, so we ought to be able to work with >any >1.5 release >= 1.5.4. > >> bitbake: toaster: enable debug mode > >You don't say *why* you're enabling this for all users - we don't >normally >turn on BBDEBUG by default. Why is this needed? > >> bitbake: toaster: save extra data related to executed tasks >> >>+import pprint > >This doesn't seem to be needed. > >> + 'workdir' : d.getVar("WORKDIR", True), > >We can't do this. Apart from a few bits of old code that really >shouldn't, >Bitbake knows nothing about WORKDIR, and that's intentional. If you >absolutely >need this, you'll need to collect it another way. I'm not even sure it >makes >sense when we're talking about a remote context, which we are going to be >in >soon; perhaps we should review how we handle this at the design level. Well, I guess we either show it or not. The reason why I thought this piece of information would be useful is that the work directory contains a whole bunch of files people might want to look into (package source, etc). It is handy to be told where they are instead of having to look for them. It also opens the possibility of remote access to those files, if we ever want to provide that. But I could be wrong, of course. > >> + 'filename' : d.getVarFlag(t, "filename"), >> + 'lineno' : d.getVarFlag(t, "lineno"), > >I've run this past Richard, and he thinks that we should try partially >enabling the variable tracking just for functions - sorry for going back >and >forth on this. What we'd need to do is check the performance impact of >doing >so - would you be able to look into that? > >Cheers, >Paul > >-- > >Paul Eggleton >Intel Open Source Technology Centre >_______________________________________________ >toaster mailing list >[email protected] >https://lists.yoctoproject.org/listinfo/toaster _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
