I was asked to review the state of all machines page (https://bugzilla.yoctoproject.org/show_bug.cgi?id=6593 currently assigned to Michael) to give an idea of how much work is left to do. The short answer is: quite a bit.
This is the list of issues I've found * The "Show rows" menu doesn't seem to be working properly. When you load the page, the table always shows 10 rows, independently of the value selected in the "show rows" menu * The machine name should not have a blue icon next to it * The machine file information is not coming in * The layer name should be a link to the layer details page * The branch, tag or commit column always shows a commit. For machines coming from layers from the OpenEmbedded layer source, this column should be showing a branch name instead * The help text in the "add layer" buttons is currently hardcoded (it shows the same layer name for all machines) * You cannot add layers / select machine functionality is not in place * The 'layer' column should be sortable (currently isn't) * Sorting and the "edit columns" menu do not interact as explained in page 21 of the design document * Sorting by layer source reverts the sorting by machine, setting it to z to a. This should not happen: when I sort by layer source, machines with the same layer source should be sorted in alphabetical order (a to z) * The "select" column filter is not in place * When applying a filter, the page heading does not update to show the number of results returned by the filter * It doesn't look like the search functionality is in place. When you try to search, you get an error saying that the "Machine object has no attribute 'search_allowed_fields'". This is the full trace: Environment: Request Method: GET Request URL: http://0.0.0.0:8000/toastergui/machines/?orderby=name%3A%2B&count=10&search =3g&page=1 Django Version: 1.6 Python Version: 2.7.3 Installed Applications: ('django.contrib.auth', 'django.contrib.contenttypes', 'django.contrib.messages', 'django.contrib.sessions', 'django.contrib.admin', 'django.contrib.staticfiles', 'django.contrib.humanize', 'orm', 'toastermain', 'south', 'toastergui', 'bldviewer', 'bldcontrol') Installed Middleware: ('django.middleware.common.CommonMiddleware', 'django.contrib.sessions.middleware.SessionMiddleware', 'django.middleware.csrf.CsrfViewMiddleware', 'django.contrib.auth.middleware.AuthenticationMiddleware', 'django.contrib.messages.middleware.MessageMiddleware') Traceback: File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py" in get_response 114. response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in machines 2383. queryset_with_search = _get_queryset(Machine, queryset_all, None, search_term, ordering_string, '-name') File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in _get_queryset 234. queryset = _get_search_results(search_term, queryset, model) File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in _get_search_results 201. model.search_allowed_fields) Exception Type: AttributeError at /toastergui/machines/ Exception Value: type object 'Machine' has no attribute 'search_allowed_fields' Cheers Belén -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
