Update 2
HEAD @ commit 469c5b7428248935ea3b95228e5292445e34de96
poky-contrib michaelw/all-machines


On 30/01/15 18:49, Michael Wood wrote:
Current work in progress available for testing at poky-contrib michaelw/all-machines

(If there's no in-line comment it's an item that's still TODO).

Michael

On 06/11/14 16:53, Barros Pena, Belen wrote:
I was asked to review the state of all machines page
(https://bugzilla.yoctoproject.org/show_bug.cgi?id=6593 currently assigned
to Michael) to give an idea of how much work is left to do. The short
answer is: quite a bit.

This is the list of issues I've found


* The "Show rows" menu doesn't seem to be working properly. When you load
the page, the table always shows 10 rows, independently of the value
selected in the "show rows" menu
Fixed


* The machine name should not have a blue icon next to it
Fixed

* The machine file information is not coming in
Unfortunately we have no information available on the machine file that I can find to display


Fixed (update 2)


* The layer name should be a link to the layer details page
Fixed

* The branch, tag or commit column always shows a commit. For machines
coming from layers from the OpenEmbedded layer source, this column should
be showing a branch name instead


Fixed (update 2)


* The help text in the "add layer" buttons is currently hardcoded (it
shows the same layer name for all machines)
Fixed

* You cannot add layers / select machine functionality is not in place
Fixed - Apart from the funny tooltip thing will come back to this

* The 'layer' column should be sortable (currently isn't)

Fixed (update 2)


* Sorting and the "edit columns" menu do not interact as explained in page
21 of the design document

* Sorting by layer source reverts the sorting by machine, setting it to z
to a. This should not happen: when I sort by layer source, machines with
the same layer source should be sorted in alphabetical order (a to z)


* The "select" column filter is not in place


Fixed (update 2)

* When applying a filter, the page heading does not update to show the
number of results returned by the filter



Was this for filters or Search? I've implemented it for search but I didn't see in the designs the same thing happens for filters.


* It doesn't look like the search functionality is in place. When you try
to search, you get an error saying that the "Machine object has no
attribute 'search_allowed_fields'". This is the full trace:
Think this last one is fixed at least I couldn't reproduce it. The no results state is missing.

--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Reply via email to