On 03/07/2015 17:41, "Michael Wood" <[email protected]> wrote:
>Early review for the top level navigation changes. > >At the moment this doesn't include the project page content changes you >can see in the design documents in #7329 and just deals with navigation. Thanks, Michael. This is looking pretty good. Most of the issues I've found are just related to small label changes and content formatting (see list below). I'd rather have the changes to the project configuration content in before merging this though, if that's ok. And here comes the dreaded list ;) * The 'Builds' tab should show only when the project has 1 or more builds. Since showing the 'Configuration' tab on its own would be a bit weird, we can leave as is for the moment until we add the 'My image recipes' tab * The 'Builds' tab should link to the project builds page, not to the all builds page * In the breadcrumb we provide in the layer details page, the project name should go to the 'Builds' tab when the number of builds in the project is 1 or more, and to the 'Basic configuration' page when the number of builds in the project is 0. * Since we now have that beautiful global nav, we can remove the "Show all builds" / "Show all projects" control in the all builds table. * In the build form, in the top right of the page, the help bubble inside the 'build' button is not working (the tooltip doesn't show) * We need to review the labels and headings across the pages in the the left navigation: ** In the Bitbake variables page, the heading should say 'Bitbake variables, should be a h2 and should not be wrapped in a page-header div ** Until we implement the separation between the software recipes and the image recipes, the label in the left navigation should simply say "Recipes" instead of "Software recipes". The heading should say "Compatible recipes" and should not be wrapped in a page-header div ** In the "Machines" page, the heading should say "Compatible machines" and should not be wrapped in a page-header div ** In the "Layers" page, the heading should say "Compatible layers" and should not be wrapped in a page-header div * In the recipes, machines and layers pages the placeholder text in the search input field should match the headings above. * The recipes, machines and layers pages table content seems to be inside the page-header div, which adds a grey line after the data table. * In the Import layer page, the heading should be a h2 and should not be wrapped in a page-header div. We can also remove the additional padding left we are setting inline for the help text at the top, and for the fieldset tag in line 182 of default.css. We can also remove the class form-actions from the div with id form-actions and replace it with the class air. That will left-align all form content nicely Thanks! Belén > > >commit 11abeda281714f46251aec1fe8b00d21d4a1b5d0 >Author: Michael Wood <[email protected]> >Date: Fri Jul 3 11:51:13 2015 +0100 > > bitbake: toaster: base Fix html indentation > > Signed-off-by: Michael Wood <[email protected]> > >commit 8cdb4d5eda48071565f278b6cc3ca0a9888b39cc >Author: Michael Wood <[email protected]> >Date: Thu Jun 25 19:21:31 2015 +0100 > > bitbake: toaster: Implement new project navigation > > Change the structure of the project page to include a navigation menu > and top tab navigation. Remove old breadcrumb method. > > [YOCTO #7329] > > Signed-off-by: Michael Wood <[email protected]> > >commit 4ca644fb3068807622a4cac1a30795399aa3c31a >Author: Michael Wood <[email protected]> >Date: Wed Jun 24 18:44:32 2015 +0100 > > bitbake: toaster: Implement new top navigation design > > Additional items for top level navigation. This is part of a wider > navigation refactoring. > > [YOCTO #7329] > > Signed-off-by: Michael Wood <[email protected]> > > >-- >_______________________________________________ >toaster mailing list >[email protected] >https://lists.yoctoproject.org/listinfo/toaster -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
