WIP with the fixes (for design review only): michaelw/toaster/wip-nav-project-changes


On 06/07/15 12:26, Barros Pena, Belen wrote:
* The 'Builds' tab should show only when the project has 1 or more builds.
Since showing the 'Configuration' tab on its own would be a bit weird, we
can leave as is for the moment until we add the 'My image recipes' tab
Done
* The 'Builds' tab should link to the project builds page, not to the all
builds page

Yeah it does link to the project builds page, however there is a server side exception redirect that does /project/x/build/ to /builds/ for some reason.

https://bugzilla.yoctoproject.org/show_bug.cgi?id=7995



* In the breadcrumb we provide in the layer details page, the project name
should go to the 'Builds' tab when the number of builds in the project is
1 or more, and to the 'Basic configuration' page when the number of builds
in the project is 0.

Done


* Since we now have that beautiful global nav, we can remove the "Show all
builds" / "Show all projects" control in the all builds table.
Done

* In the build form, in the top right of the page, the help bubble inside
the 'build' button is not working (the tooltip doesn't show)

Hm the tooltip event doesn't get triggered in firefox but does in chrome if it's inside a button element. I've moved it to the left of the input box as agreed.


* We need to review the labels and headings across the pages in the the
left navigation:

** In the Bitbake variables page, the heading should say 'Bitbake
variables, should be a h2 and should not be wrapped in a page-header div
Done
** Until we implement the separation between the software recipes and the
image recipes, the label in the left navigation should simply say
"Recipes" instead of "Software recipes". The heading should say
"Compatible recipes" and should not be wrapped in a page-header div
Done

** In the "Machines" page, the heading should say "Compatible machines"
and should not be wrapped in a page-header div
Done

** In the "Layers" page, the heading should say "Compatible layers" and
should not be wrapped in a page-header div
Done

* In the recipes, machines and layers pages the placeholder text in the
search input field should match the headings above.
Done

* The recipes, machines and layers pages table content seems to be inside
the page-header div, which adds a grey line after the data table.
Done (think that was fixed by ** #2)

* In the Import layer page, the heading should be a h2 and should not be
wrapped in a page-header div. We can also remove the additional padding
left we are setting inline for the help text at the top, and for the
fieldset tag in line 182 of default.css. We can also remove the class
form-actions from the div with id form-actions and replace it with the
class air. That will left-align all form content nicely
Done
--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Reply via email to