On 3 September 2015 at 09:13, Smith, Elliot <[email protected]> wrote:
> On 3 September 2015 at 07:15, Reyna, David L (Wind River) < > [email protected]> wrote: > >> It appears that a fix for 8187 in included in "[Toaster] >> [review-request][PATCH 1/3] toaster: hide irrelevant". >> >> - queryset = Build.objects.filter(outcome__lte = Build.IN_PROGRESS) >> + queryset = Build.objects.filter(project_id = pid) >> >> We might as well make my 8187 a duplicate of Elliot's 8236, and be done >> with it. >> > > I think you're right, David. However, the patch you submitted has some > extra stuff in it which mine doesn't. It could be that I've missed > something. I will compare the two today and see if there's anything we need > from your patch which isn't in mine. > > Let me just mention that the patch I'm submitting is an update of a stray > inherited branch I'm trying to clean up. The branch did several things, > some of which weren't attached to bugs and were incidental fixes. It was > accidental that it overlapped with the work you were doing. I'll try to > avoid duplication like this in future. > I've looked at David's patch alongside the work Alex did, and it looks like the two patches do solve the same issue, just in different ways: Alex rewrites the URL directly on the RedirectException, while David does it in the _build_list_helper() method. I prefer David's method. I will attempt to merge the two into my branch by cherry-picking David's commit to get the better method implementation. Elliot -- Elliot Smith Software Engineer Intel Open Source Technology Centre
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
