On 03/09/2015 11:38, "Smith, Elliot" <[email protected]> wrote:
>On 3 September 2015 at 11:03, Barros Pena, Belen ><[email protected]> wrote: > >On 03/09/2015 03:14, "Brian Avery" <[email protected]> wrote: > >>A bug (small): >>In progress build does not appear on the project build page until it >>has completed. The # next to the builds(##) at the top of the page >>shows 1 even during the build. > >https://www.dropbox.com/s/z5iv03fmn0mhehx/Screenshot%202015-09-02%2017.39. >4 >1.png?dl=0 > >This is a bug (thanks for spotting it): it should be showing 0. Builds are >not shown in tables or added to counters until they complete. When you >have a project with a build in progress and 0 builds completed, the page >should look as shown in the attached file. > > > > >Thanks for pointing that out, I will fix it. Does everything else look >correct? I think so. > > >I don't think that queued builds are displayed as shown in your image on >the master branch. Do we have a bug for that already? Yes. It was set to 'low' in yesterday's call: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8242 I'd love to see it fixed though. Cheers Belén > > >(I suggest we don't include a fix for that in this branch, as it is not >related to the specific bug I'm working on [8236].) > > >Elliot > > > >>On Wed, Sep 2, 2015 at 7:11 PM, Brian Avery <[email protected]> >>wrote: >>> Question: >>> How does this interact with the default_proj you did? I couldn't >>> apply this patchset on top of that one and I upstreamed the >>> default_proj first. >>> >>> When I did a quick apply by hand, I got errors when I tried to go look >>> at the "command line proj" page, but that may have been my mistake. >>> >>> We should probably make sure that this interacts ok with the >>> default_proj changes. >>> -b >>> >>> On Wed, Sep 2, 2015 at 9:22 AM, Barros Pena, Belen >>> <[email protected]> wrote: >>>> >>>> >>>> On 02/09/2015 17:04, "[email protected] on behalf of >>>>Elliot >>>> Smith" <[email protected] on behalf of >>>> [email protected]> wrote: >>>> >>>>>Hide "in progress" builds everywhere, and only show builds for >>>>>the currently-open project on the /project/X/builds page. >>>>> >>>>>Changes since 71b0568fa43285f0946fae93fb43cea5f3bbecec are in >>>>>git://git.yoctoproject.org/poky-contrib >>>>><http://git.yoctoproject.org/poky-contrib>, >>>>>elliot/toaster/hide_builds-8236 >>>>>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaste >>>>>r >>>>>/hi >>>>>de_builds-8236 >>>> >>>> The UI seems to be working correctly: >>>> >>>> * Builds in progress no longer show >>>> * Only the builds for the selected project are shown >>>> >>>> The latter means that this bug also fixes >>>> >>>> >https://bugzilla.yoctoproject.org/show_bug.cgi?id=8187 ><https://bugzilla.yoctoproject.org/show_bug.cgi?id=8187> >>>> >>>> Which was assigned to David Reyna, who had a patch out for review, I >>>> believe. >>>> >>>> Just bringing it up so you can decide which one should go in. >>>> >>>> Cheers >>>> >>>> Belén >>>> >>>>> >>>>>Related bug: >https://bugzilla.yoctoproject.org/show_bug.cgi?id=8236 ><https://bugzilla.yoctoproject.org/show_bug.cgi?id=8236> >>>>> >>>>>Alexandru DAMIAN (1): >>>>> toaster: hide irrelevant builds in the project builds view >>>>> >>>>>Elliot Smith (2): >>>>> toaster: Remove cast to date which causes errors during test >>>>> toaster: Add tests for /project/X/builds page >>>>> >>>>> bitbake/lib/toaster/toastergui/tests.py | 91 >>>>>++++++++++++++++++++++++++++++++- >>>>> bitbake/lib/toaster/toastergui/views.py | 59 +++++++++++++++------ >>>>> bitbake/toaster-requirements.txt | 1 + >>>>> 3 files changed, 134 insertions(+), 17 deletions(-) >>>>> >>>>>-- >>>>>Elliot Smith >>>>>Software Engineer >>>>>Intel OTC >>>>> >>>>>--------------------------------------------------------------------- >>>>>Intel Corporation (UK) Limited >>>>>Registered No. 1134945 (England) >>>>>Registered Office: Pipers Way, Swindon SN3 1RJ >>>>>VAT No: 860 2173 47 >>>>> >>>>>This e-mail and any attachments may contain confidential material for >>>>>the sole use of the intended recipient(s). Any review or distribution >>>>>by others is strictly prohibited. If you are not the intended >>>>>recipient, please contact the sender and delete all copies. >>>>> >>>>>-- >>>>>_______________________________________________ >>>>>toaster mailing list >>>>>[email protected] >>>>>https://lists.yoctoproject.org/listinfo/toaster >>>> >>>> -- >>>> _______________________________________________ >>>> toaster mailing list >>>> [email protected] >>>> >https://lists.yoctoproject.org/listinfo/toaster ><https://lists.yoctoproject.org/listinfo/toaster> > > > > > > > > > > >-- >Elliot Smith >Software Engineer >Intel Open Source Technology Centre > > > > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
