On 16 May 2016 at 13:32, Barros Pena, Belen <[email protected]> wrote:
> On 13/05/2016 08:11, "[email protected] on behalf of sujith > h" <[email protected] on behalf of [email protected]> > wrote: > > >I have created a branch for addition of new imagefs types: > > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-n > >ew-image-type-7828 > >< > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add- > >new-image-type-7828> ( reference: > >https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828). The top commit > >of this branch needs review. Thanks a bunch to Michael and Belen for > >helping me figure out the issue of disabling of > > save button in firefox. > Hello Sujith. Thanks for your patches. They generally look good, but I have a couple of comments: 1. While Toaster JS code doesn't always adhere to its own style guides (something we will hopefully address eventually), it will help us if new code *is* consistent with our guide where possible. You can find it at: https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Javascript In particular, please note how we prefer to lay out if...then blocks. 2. Toaster's test coverage isn't anywhere near as complete as we'd like, but we do try to provide tests for UI code where possible now that we have a framework for that in place. Your patch covers a case where a UI test would make sense. Would it be possible for you to write some tests to cover your code, please? You can find the existing tests in bitbake/lib/toaster/tests/browser/, along with a sample test template. If you need any help with either, please get in touch with me. Thanks. Elliot > > This seems to be working for me, both setting up the IMAGE_FSTYPES value > and building with a custom value (I tried building rpi-basic-image from > meta-raspberrypi adding rpi-sdimg as an image type). > > I've pushed a small patch to the branch to fix a couple of tiny > presentation issues and to add a label: > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add > -new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1 > > > With that in, I am good with it. Code should be reviewed though. > > Thanks! > > Belén > > > > >-- > >സുജിത് ഹരിദാസന് > >Bangalore > ><Project>Contributor to KDE project > > > ><Project>Contributor to Yocto project > > > >http://fci.wikia.com/wiki/Anti-DRM-Campaign > ><Blog> http://sujithh.info > > > >C-x C-c > > > > > > > > > > > > > > > > > > -- > _______________________________________________ > toaster mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/toaster > -- Elliot Smith Software Engineer Intel Open Source Technology Centre
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
