On Tue, May 17, 2016 at 9:50 PM, Smith, Elliot <[email protected]> wrote:
> On 17 May 2016 at 15:02, sujith h <[email protected]> wrote: > >> Hi Elliot, >> >> I have updated >> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-new-image-type-7828 >> The top most commit comprises of a test case which you have suggested. >> Kindly let me know if you are ok >> with the changes. >> > > These look good, and very quickly done, too, thanks. > > I think there is another case which isn't covered by the tests, however > (if I read the code correctly): if the user deletes the text from the > textbox (with backspace or delete), and removes a file type, the > corresponding checkbox should be unchecked. That case isn't covered as far > as I can see. > > Also, the test_checkbox_verification() test you do have doesn't test the > values of the checkboxes after you enter "btrfs" in the text box. > > It would be good to get those changes in. > I have added those changes also in http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-new-image-type-7828 . Let me know how the current state of the patch looks. Thanks for the feedback. > > Thanks. > Elliot > > >> >> Thanks, >> Sujith H >> >> >> On Mon, May 16, 2016 at 6:57 PM, sujith h <[email protected]> wrote: >> >>> >>> >>> On Mon, May 16, 2016 at 6:25 PM, Smith, Elliot <[email protected]> >>> wrote: >>> >>>> On 16 May 2016 at 13:32, Barros Pena, Belen < >>>> [email protected]> wrote: >>>> >>>>> On 13/05/2016 08:11, "[email protected] on behalf of >>>>> sujith >>>>> h" <[email protected] on behalf of [email protected]> >>>>> wrote: >>>>> >>>>> >I have created a branch for addition of new imagefs types: >>>>> > >>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add-n >>>>> >ew-image-type-7828 >>>>> >< >>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/add- >>>>> >new-image-type-7828> ( reference: >>>>> >https://bugzilla.yoctoproject.org/show_bug.cgi?id=7828). The top >>>>> commit >>>>> >of this branch needs review. Thanks a bunch to Michael and Belen for >>>>> >helping me figure out the issue of disabling of >>>>> > save button in firefox. >>>>> >>>> >>>> Hi Elliot, >>> >>> >>>> Hello Sujith. >>>> >>>> Thanks for your patches. They generally look good, but I have a couple >>>> of comments: >>>> >>>> 1. While Toaster JS code doesn't always adhere to its own style guides >>>> (something we will hopefully address eventually), it will help us if new >>>> code *is* consistent with our guide where possible. You can find it at: >>>> https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Javascript In >>>> particular, please note how we prefer to lay out if...then blocks. >>>> >>> >>> I have pushed new changes at >>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=be85f177959bafddbdbaefe0cf57f02a74adf78a >>> Hope this looks much better and cleaner. >>> >>> >>>> >>>> 2. Toaster's test coverage isn't anywhere near as complete as we'd >>>> like, but we do try to provide tests for UI code where possible now that we >>>> have a framework for that in place. Your patch covers a case where a UI >>>> test would make sense. Would it be possible for you to write some tests to >>>> cover your code, please? You can find the existing tests in >>>> bitbake/lib/toaster/tests/browser/, along with a sample test template. >>>> >>> >>> Sure I would like to write the tests. Let me go through the path shared >>> by you. In case of any queries of help required I will get back to you. >>> >>> Thanks for the feedback. >>> >>> >>>> >>>> If you need any help with either, please get in touch with me. >>>> >>>> Thanks. >>>> Elliot >>>> >>>> >>>> >>>> >>>>> >>>>> This seems to be working for me, both setting up the IMAGE_FSTYPES >>>>> value >>>>> and building with a custom value (I tried building rpi-basic-image from >>>>> meta-raspberrypi adding rpi-sdimg as an image type). >>>>> >>>>> I've pushed a small patch to the branch to fix a couple of tiny >>>>> presentation issues and to add a label: >>>>> >>>>> >>>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add >>>>> -new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1 >>>>> <http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/add-new-image-type-7828&id=2c85b933dd86b53dc16490f7912f63f1d8c417d1> >>>>> >>>>> >>>>> With that in, I am good with it. Code should be reviewed though. >>>>> >>>>> Thanks! >>>>> >>>>> Belén >>>>> >>>>> > >>>>> >-- >>>>> >സുജിത് ഹരിദാസന് >>>>> >Bangalore >>>>> ><Project>Contributor to KDE project >>>>> > >>>>> ><Project>Contributor to Yocto project >>>>> > >>>>> >http://fci.wikia.com/wiki/Anti-DRM-Campaign >>>>> ><Blog> http://sujithh.info >>>>> > >>>>> >C-x C-c >>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>>> >>>>> -- >>>>> _______________________________________________ >>>>> toaster mailing list >>>>> [email protected] >>>>> https://lists.yoctoproject.org/listinfo/toaster >>>>> >>>> >>>> >>>> >>>> -- >>>> Elliot Smith >>>> Software Engineer >>>> Intel Open Source Technology Centre >>>> >>> >>> >>> >>> -- >>> സുജിത് ഹരിദാസന് >>> Bangalore >>> <Project>Contributor to KDE project >>> <Project>Contributor to Yocto project >>> http://fci.wikia.com/wiki/Anti-DRM-Campaign >>> <Blog> http://sujithh.info >>> C-x C-c >>> >> >> >> >> -- >> സുജിത് ഹരിദാസന് >> Bangalore >> <Project>Contributor to KDE project >> <Project>Contributor to Yocto project >> http://fci.wikia.com/wiki/Anti-DRM-Campaign >> <Blog> http://sujithh.info >> C-x C-c >> > > > > -- > Elliot Smith > Software Engineer > Intel Open Source Technology Centre > -- സുജിത് ഹരിദാസന് Bangalore <Project>Contributor to KDE project <Project>Contributor to Yocto project http://fci.wikia.com/wiki/Anti-DRM-Campaign <Blog> http://sujithh.info C-x C-c
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
