> -----Original Message----- > From: Bill Barker [mailto:[EMAIL PROTECTED] > Sent: Saturday, June 04, 2005 1:27 PM > To: Tomcat Developers List > Subject: Re: cvs commit: > jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/htt > p/mapper HostMap.java Mapper.java > > > ----- Original Message ----- > From: "Remy Maucherat" <[EMAIL PROTECTED]> > To: "Tomcat Developers List" <[email protected]> > Sent: Saturday, June 04, 2005 10:29 AM > Subject: Re: cvs commit: > jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/htt > p/mapper > HostMap.java Mapper.java > > > >Peter Rossbach wrote: > >> Hey Remy, > >> > >> For usefull feature I don't give up :-) > > > >Fine, I'll just revert your patch then ;) > > > >> The default of host alias matching is off. The current > implementation is > >> little bit fast > >> then the old one. (Great) Every user of this feature can limit the > >> dynamic host addition with > >> <Connector port="8080" allowedAliasMatches="10" /> > > > >The issue is that this mechanism is bad, period. > > I have to agree with Remy on this. The issue is that the > code is just plain > bad :(. So I'm going to add my -1 to the patch until the
There's no justification here. Explain why you think the code is "bad" it's actually a hell of a lot cleaner and easier to follow than the original code, and it's 15% faster. What exactly are your criteria for measuring goodness. > mechanism is > cleaned up. In fact, I'd have -1ed it just for the "import > com.sun....." > line alone. > I don't know what you are looking at. My submission had NO com.sun.xxx class imports. Perhaps you missed the thread where I said I rewrote it? http://www.mhsoftware.com/~gsexton/HostMap.java http://www.mhsoftware.com/~gsexton/Mapper.java If you are going to -1 some code, you should at least look at it. George Sexton MH Software, Inc. http://www.mhsoftware.com/ Voice: 303 438 9585 --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
