On 18 Aug 2001 19:56:33 +0200, Paulo Gaspar wrote:
> I have been trying to improve a bit on the "admin"
> application, especially on the "contextAdmin" bit,
> tweaking its web pages/JSPs in order to add functionality
> and ease of use.
Great :-)
> I am especially interested on making it easier to restart
> individual applications, deploy or redeploy new
> applications and restart the whole container trough this
> web interface.
> The first two things that are really confusing are:
> - the existence of 2 lines of very similar classes
> (e.g.: TomcatAdmin and ContextAdmin) in the "tadm"
> package at "webapps\admin\WEB-INF\classes\tadm";
Well, TomcatAdmin is the first tag I wrote, and it did a lot of things.
Too many, actually, so I started to split it. ContextAdmin will focus on
context tasks, TomcatAdmin for generic tomcat.
Also, TomcatAdmin declares the "ContextManager" scripting variable, and
that's a problem to be fixed - you can have only one <tadm:admin> in a
page right now.
> - and the fact that "restart.jsp" does not work as
> expected producing duplicate entries in the list
> presented by "contextList.jsp".
That's a bug. I'll take a look, I wrote restart.jsp mostly as a test -
to make sure all modules are cleaning up after themself ( i.e. you do
restart.jsp few times and check the thread count, memory use, etc - it
should stay constant ). If some contexts are not removed - that must be
fixed ( please add a bug so I'll remember ).
> Looking at "org.apache.tomcat.core.ContextManager" did
> not help a lot since its comments are not very clear
> either, as is the case of its "shutdown()" method where
> comments make me doubt about how cleanup should be done.
Ok, what's not clear :-) ? As you know, I'm not very good at docs, but
if you ask specific questions I may be able to answer ( and fix the
comments allong the way ).
> This restart thing probably has some relation with the
> work Costin is doing on "EmbededTomcat" - maybe the
> information missing is the same.
It has some relation, in the sense EmbeddedTomcat must be able to
restart ( and it's using the same calls as restart.jsp ).
Costin
