My current 'preference' is to use r->uri, as in the main branch ( and how
it used to be ). That keeps rewrite working and is consistent with most
apache modules.

The downside is that we're on the edge of the spec, which require the
'original' URI. However, since HTTP seem to allow proxies to alter
(normalize) the URI, on some server the 'original' URI is not
available, and the servlet spec covers only the servlet container, not the
web server - and we'll keep whatever enter the servlet container
unchanged - I believe using r->uri is a decent solution.

If the servlet spec would be interpreted to mean 'the URI that the user
typed' - then I believe that's impossible to implement anyway ( at least
on browser alters that ).

I'm not very sure - but beeing consistent across the servers and
consistent with what other modules and server-side programs are doing
seems a good argument.

Costin

On Wed, 12 Sep 2001, Larry Isaacs wrote:

> One of the main aspects of this issue is for me to
> become informed as to the state of Tomcat 3.3's mod_jk
> with respect to this.  Tomcat 3.3's mod_jk.c has:
>
>     s->req_uri = r->uri;
>
> which, by the statement below, appears to be "rewrite"
> enabled.  This might explain why it works for Bill.
>
> I recall there being a discussion on tomcat-dev a
> while back about this, but I don't recall the final
> resolution, or if there was one. Formally establishing
> this "resolution"  for Tomcat 3.3 was my reason for
> including item 11.
>
> Thanks,
> Larry
>
> > -----Original Message-----
> > From: Keith Wannamaker [mailto:[EMAIL PROTECTED]]
> > Sent: Wednesday, September 12, 2001 3:11 PM
> > To: [EMAIL PROTECTED]
> > Subject: RE: Remaining Tomcat 3.3 Issues
> >
> >
> > mod_jk uses (used?) r->unparsed_uri to preserve encoding.
> > Therefore, any mod_rewrite munging of r->uri is invisible
> > to mod_jk.  This is the issue to which Larry is referring,
> > not Apache module ordering.
> >
> > Keith
> >
> > | -----Original Message-----
> > | From: Bill Barker [mailto:[EMAIL PROTECTED]]
> > | Sent: Wednesday, September 12, 2001 2:30 PM
> > | To: [EMAIL PROTECTED]
> > | Subject: Re: Remaining Tomcat 3.3 Issues
> > |
> > |
> > | Re. 11)  I use mod_rewrite + mod_jk regularly without
> > problems.  The problem
> > | is that the "out-of-the-box" model order puts mod_jk ahead
> > of mod_rewrite.
> > | The trick to make them play happily together is to simply
> > re-order them in
> > | httpd.conf.  Of course, this has the downside that you
> > can't use the file
> > | generated by ApacheConfig verbatim.  But if you want
> > advanced functionality,
> > | you have to expect to fiddle with the configuration.
> >
>

Reply via email to