Hi,
Tomcat 5.0 always adds a charset=ISO-8859-1 to the content type. While this is I think relatively legal, it is rather risky (it causes problems with some clients, as I've read on tomcat-user), and very dubious when dealing with non text data.
Example: GET /tomcat.gif HTTP/1.0 User-Agent: ApacheBench/1.3d Host: 127.0.0.1 Accept: */*
HTTP/1.1 200 OK ETag: W/"1934-1068549702000" Last-Modified: Tue, 11 Nov 2003 11:21:42 GMT Content-Type: image/gif;charset=ISO-8859-1 Content-Length: 1934 Date: Tue, 11 Nov 2003 14:59:56 GMT Server: Apache-Coyote/1.1 Connection: close
(lol)
Maybe Jan's changes to charset handling caused that.
If charset is not explicitely added, I think it should not be added to content-type either.
Other than that, 5.0.14 looks quite good :)
I have fixed it, but the patch which caused it is not very optimal, as it uses String concatenations. IMO, if the user sets the full String (including the charset) using setContentType, then we should probably use it rather than reconstruct it again.
I'll do a performance analysis to make sure there are no regressions (after all, similar problems could have been introduced).
Rémy
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
