----- Original Message -----
Sent: Monday, April 05, 2004 5:55 PM
Subject: cvs commit:
CoyoteAdapter.java CoyoteOutputStream.java CoyoteReader.java
CoyoteRequest.java CoyoteWriter.java

> jfarcand    2004/04/05 17:55:07
>   Modified:    catalina/src/share/org/apache/coyote/tomcat5
>                         CoyoteAdapter.java CoyoteOutputStream.java
>                         CoyoteReader.java CoyoteRequest.java
>                         CoyoteWriter.java
>   Log:
>   Add public method consistently. Currently some methods were private,
some final
>   and some public.

I'm -0 on this.  The classes modified are all internal to the Tomcat 5.x
CoyoteConnector, so there is no good reason to make them public.

>   Making such classes public allowed re-utilization of those classes as a
base for new connector( ex: NSAPI)

The way that Coyote is designed, this should always be unnecessary.  The way
to build a new connector is to define a new ProtocolHandler that deals with
the transport.

This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to