Howdy, I would caution you to look at the code of small, focused projects first. It's easier to keep to best practices and consistent style in smaller projects. Tomcat does a whole lot, has many features, lots of pluggable entities, so the design would appear overly complex to anyone not aware of the many nuances. That said, tomcat code is excellent IMHO.
Yoav Shapira Millennium ChemInformatics >-----Original Message----- >From: Tim Funk [mailto:[EMAIL PROTECTED] >Sent: Monday, December 08, 2003 9:55 AM >To: Tomcat Users List >Subject: Re: [OT] Quality of open source code - not a survey. > > From a style point of view - tomcat is not very strict on style. Thats not >saying that the style is bad, but we concentrate on code quality, not >programming style. But if a patch has bad programming style, hindering the >code readability and intent, then someone will complain. > >So in a nutshell, tomcat committers makes every attempt to ensure the code >is >readable, but its style may not be consistent. > >IIRC, the projects which are most strict with respect to style is Maven and >Avalon related projects. > >-Tim > >Antony Paul wrote: > >> Hi, >> I am not questioning quality of opens source projects. My intention >is >> to learn from looking at the source code of open source projects. I want >to >> know whether it is good to learn from looking at the source code of this >> kind of projects. I want to develop best coding practices and know how >> things work and how to implement it. To learn it, the cheap way available >> to me is looking at code written by some experts. I believe people who >wrote >> Tomcat,JSTL and other have godd knowledge of Java. Is there anything >wrong >> in doing such things ? >> > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]