On Wed, Aug 16, 2006 at 01:23:32PM -0700, Mike Kupfer wrote: > > 6455242 nightly should be able to preserve all proto areas from a > > single build. > > I took a quick look at this. I'm happy with the basic approach, but the > PROTO_AREAS thing seems clunky. Is there any reason not to set > PROTO_AREAS to "multi", other than a desire to save on disk space?
That's pretty much it. Well, that, and if anyone expects a non-debug build to end up in $ROOT and not $ROOT-nd. I agree that PROTO_AREAS is clunky -- it'd originally started out as a list of the paths to the proto areas, but that just seemed like too much control. I thought about a flag for nightly to turn it on/off, but that seemed too high-level. If you have a good idea for a name for a boolean variable, I'm happy to change it, or if you have a good flag idea, ditto (EHJKLOQVYZbceghjkqsvwy is available). I'm really bad with names. > Could we drop PROTO_AREAS, so that there are always two proto areas (one > for debug and one for non-debug)? If that's not feasible, could we at > least make PROTO_AREAS=multi the default? Well, I'm a bit hesitant to make it the default, if for no other reason than we just got another proto-area doubler (wsdiff), and this would make it four copies. Public build machines are already having problems with enough storage, and this wouldn't help. Besides, I don't think most people actually care. I don't think too many people do incrementals and expect to get usable debug and non-debug bits out of it. This is mostly a gatekeeper kind of thing (and whoever else is releasing the bits in some fashion). I'd rather make it the default after a while, if it turns out that the general public is using it this way. Danek _______________________________________________ tools-discuss mailing list [email protected]
