Okay, I reviewed the updated webrev. It generally looks good to me.
I've got 2 concerns:
1. The changes to usr/src/pkgdefs/Makefile.com are pretty opaque unless
you're looking at usr/src/pkgdefs/Makefile.targ at the same time.
Comments are definitely needed here.
Here's some suggested verbage:
#
# Magic to generate the list of files that a package depends on. The
# basic idea is to invoke an awk script using $(...:sh). The awk script
# extracts the relevant file names from the prototype file(s), following
# "include" directives as needed. For path1=path2 constructs, use
# path2, because that's where we'll actually find the file. Type e, f,
# and v files are in the proto area. Type i files are in the package
# directory (under pkgdefs).
#
INCLPROC= /^!include/ {ARGV[ARGC]=$$2; ARGC += 1}
[...]
2. It would be good if the Evaluation of 6460124 says something about
"=" in package prototype files and why you had to change
SUNWpcmci/prototype_com. I figured it out from the new comments in
protodir.c, but having a brief explanation in Bugster would be helpful.
In fact, the comment in protodir.c about how "e" files might just be a
fragment was news to me. A sufficiently clever person might be able to
deduce it from prototype(4), but I think it would be helpful information
to include in your explanation. Or, if this is explained somewhere in
the packaging developer guide, please include a pointer to the relevant
section of the docs.
cheers,
mike
_______________________________________________
tools-discuss mailing list
[email protected]
