General comments:

DJM-1   Don't abbreviate: inserted, deleted, modified, unchanged

DJM-2   I wonder if we should have i18n/l10n support :-)

DJM-3   In Frames view it would be really nice to only have the
        bug info listed once and have it not move, but have the ability
        to make that bit (I assume another frame) be closed.


usr/src/tools/scripts/wdiff.pl

DJM-4   line 53, Why is the surrounded by <pre> this means I can't
        use HTML in my comments.  Not that I'm sure I want to but
        somebody might.  Is there something else that could be done
        here to get nice formating but allow for HTML ?

        I don't feel strongly about this at all.


Rest of this file looks okay, I think I followed all the css stuff.

usr/src/tools/scripts/webrev.1:  Not reviewed.


I hope to finish my review of the bulk of the changes in webrev.sh but I thought I've give you this and let you know I'm still looking at webrev.sh.


--
Darren J Moffat
_______________________________________________
tools-discuss mailing list
[email protected]

Reply via email to