Dan Price wrote:
On Wed 19 Jul 2006 at 05:08PM, Dan Price wrote:
Hi folks,
I've been doing some revisions to webrev, and was directed to this alias
for further review.
Well, it has taken a while, but in my spare time I've been plugging
away at my updates to webrev.
After my last posting I got a lot of mail from folks requesting that
I make their favorite change to webrev. I've picked up most, but not
all of these. Please consider additional RFE work for this wad to
be closed :) I need to be done.
This version includes further visual cleanup, a unified color vocabulary,
an "Opensolaris" mode, improved non-wx operation, an "include" mechanism,
a getopts driven command line interface, and more. The new webrev should
be mostly ready for other authors to "drop in" new SCM types (please let
me know if not) and the command line behavior is now more rational: the
default behavior is to "just do the right thing." Here's an example of
this in action, combined with the new -O (opensolaris mode):
$ webrev -O
SCM detected: teamware
File list from: wx 'active' file ... Done.
Workspace: /builds/dp/webrev-fixes
Compare against: /ws/onnv-clone
Including: /builds/dp/webrev-fixes/webrev-info
Output to: /builds/dp/webrev-fixes/webrev
Output Files:
usr/closed/foo.pl
*** Omitting closed source for OpenSolaris mode review
usr/src/tools/scripts/wdiff.pl
cdiffs udiffs wdiffs sdiffs frames patch old new
usr/src/tools/scripts/webrev.1
cdiffs udiffs wdiffs sdiffs frames patch old new
usr/src/tools/scripts/webrev.sh
cdiffs udiffs wdiffs sdiffs frames patch old new
usr/src/tools/scripts/wx.1
cdiffs udiffs wdiffs sdiffs frames patch old new
usr/src/tools/scripts/wx.sh
cdiffs udiffs wdiffs sdiffs frames patch old new
Generating PDF: Done.
index.html: Done.
Please note that the man page changes aren't done yet, but I'd like
to solicit a first round of codereview feedback on the rest:
http://cr.grommit.com/~dp/webrev.3
The results of a quick glance (at 2:30am, keep in mind):
line 1356: CODEMGR_WS will be in the environment whenever you're
bldenv'd in a workspace, and I don't see it otherwise unset
in the lead-up to this, so this isn't an accurate check for
TeamWare. It will be true in general (though other SCMs
could put their checks before this, I suppose.)
It's probably worth using the existence of $CODEMGR_WS/Codemgr_wsdata
instead. Which should only be there in TeamWare workspaces.
-- Rich
_______________________________________________
tools-discuss mailing list
[email protected]
