Richard Lowe wrote:
I think we're coming at this from different angles. As I said, my hope is that for complete migration, the gate will refuse the kind of bogus putback that would induce an undo, so at that point they will cease entirely.
undo/backout is not just done for "nit" like wrong commenting bad RTI etc. It can also be done because the new code introduces a really bad regression and is discovered before the build is closed. Some times the developers are given a change to do a follow up integration to fix the bug but in other cases there either isn't time or the bad code is so toxic it needs to get out of the gate asap. One example of really toxic code would be stuff that passes all the "nits" tests but just plain fails to build or causes lots of build issues for others even if it does.
BTW here speaks the voice of experience, I did such a putback once when updating openssl during Solaris 10 development. Yes I was very embarrased because everything was working fine for me in my workspaces but it causes issues in the main gate when it was integrated even though it passed all the "nits" tests that wx putback runs.
-- Darren J Moffat _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
