Stephen Hahn wrote:
* Mike Kupfer <[EMAIL PROTECTED]> [2006-11-02 12:24]:
"stevel" == Stephen Lau <[EMAIL PROTECTED]> writes:
stevel> what about a changegroup hook that only fires if there are
stevel> >10 changesets incoming, and a changeset hook that fires if
stevel> there are <=10?

I don't think an adaptive approach is appropriate here.

....

I'd rather see a single notification email, which always contains the
same level of detail.  The email could include one or more links to
pages with additional information.[2]

  Does your changesets > N format differ appreciably for changesets = 1?
  A single message format is definitely appealing.

There are a few differences:

The notification format for the 'Changesets > N' case drops the 'Revision:' field since it encompasses multiple revisions. The log msg will only log the most recent message, and will also contain a note to the effect of "This changegroup encompassed XX changesets". I'm also happy to change this something like "Changesets Included: XX" if that will make it more parse-able.

cheers,
steve


--
stephen lau // [EMAIL PROTECTED] | 650.786.0845 | http://whacked.net
opensolaris // solaris kernel development
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org

Reply via email to