Mark J. Nelson writes:
> So here's a (hopefully simple) code review request, to make the
> usr/src/pkgdefs build more robust to various SCM_TYPE settings:
>
> http://cr.opensolaris.org/~mjnelson/webrev.6815619/
>
> Response by COB today greatly appreciated.
Your COB ain't mine (;-}), but the changes look ok to me.
Down in the nits:
Personally, I prefer to see $() in makefiles rather than ${}. I can't
give a solid reason for that; just a vague recollection that the ${}
form was supposed to be obsolescent.
I somewhat more strongly prefer, though, not seeing mixed styles in a
file. This one seems to have an arbitrary mix of $() and ${}, which
is unattractive to me.
--
James Carlson, Solaris Networking <james.d.carl...@sun.com>
Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
