[...]
This whole change though makes me very nervous as I suspect it is all
driven by a misguided desire for empty sections in the nightly mail. It
should be obvious reading the nightly mail when the build was clean.
Right. Hence my being lukewarm--as an advocate, I would not accept build
logs with use of this flag.
With the option turned on the second and next builds look like first build.
The only missing stuff is "diffs since last build". You also don't have
this section in the very first build. So as CRT advocate you don't accept
the change if it was built only once? Well, it would be suspicious in case
of new fix, but in case of backport to earlier release it can easily
happen...
Which is why I suggested not having empty output, but instead explicitly
saying "the -s flag was used." But an empty noise section is already not
indicative of a clean build--it simply means that, between the previous
build and the current build, no new noise was introduced. :(
And no noise was removed.
We already have some issues with the way we process noise in the build. It's
really easy to miss something the first time it's introduced, and then you'll
never see it again, or it will be utterly lost in a flood of false
information following a failed build. This fix seems to not address any of
those real issues.
These are completely different issues.
And I believe that repeating noise from past builds is not a fix.
Vita
If the behaviour this rfe is suggesting is acceptable why isn't it the
default case, or why isn't it the only case. IMO nightly is already too
configurable.
--
Darren J Moffat
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
