Roland Mainz <roland.ma...@nrubsig.org> writes: > Roland Mainz wrote: > [snip] >> new webrev is available as >> http://cr.opensolaris.org/~gisburn/cr6842892_webrev_cleanup_002/ > > ping! - can anyone please review the changes ?
Initially, I agree with what Vladimir said in his response pretty much entirely, with the addition of: If you're really going to be generating the manual page now, why is webrev.1 showing in your webrev as modified, not removed? For that matter, does adding 315 lines of usage message to the webrev script itself really help anyone? I can't tell if you didn't hg rm webrev.1, or what is going on there. Makefile:144 It's not yours, but since you're making changes in there anyway, please fix the typo. warings -> warnings. I haven't looked at things in any great detail, so don't rely on this as review. -- Rich _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
