#22983: add a descriptor interface and implementation for web-logs
---------------------------------+-----------------------------------
 Reporter:  iwakeh               |          Owner:  metrics-team
     Type:  enhancement          |         Status:  needs_revision
 Priority:  Medium               |      Milestone:  metrics-lib 2.1.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------

Comment (by iwakeh):

 Replying to [comment:16 karsten]:
 > I think we agree on most points here.
 >
 > Just one suggestion for the `internal` package: we could label it as
 "beta" with the intention to making it a public API at a later stage,
 while reserving to break the API even between minor releases until we
 remove the "beta" label. This would give us some freedom while designing
 this new API to make mistakes and revise ideas.

 I implemented the changes along the lines we discussed in the above
 comments.
 There are plenty of tests for the new code (which already helped uncover
 subtle bugs) and javadoc for both the public and the internal parts, which
 should also address some of the questions from your first review comments.

 Please review seven commits [https://gitweb.torproject.org/user/iwakeh
 /metrics-lib.git/log/?h=task-22983-2 on this branch].  Three of these
 commits ([https://gitweb.torproject.org/user/iwakeh/metrics-
 lib.git/commit/?h=task-22983-2&id=e0c5774529fb2597e80690b5cc625e54a2eeb245
 one], [https://gitweb.torproject.org/user/iwakeh/metrics-
 lib.git/commit/?h=task-22983-2&id=e2246804e366920c9c334d774575217be0c644f8
 two], [https://gitweb.torproject.org/user/iwakeh/metrics-
 lib.git/commit/?h=task-22983-2&id=d687f440ea570bf24fd01bdbf53365686f68a1aa
 three]) are tiny maintenance commits and the other four implement this
 task.

 As a result of this patch the CollecTor patch for webstats (#22428) will
 be very small and quite some code reduction will be possible in other
 CollecTor modules.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22983#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Reply via email to