#22983: add a descriptor interface and implementation for web-logs ---------------------------------+----------------------------------- Reporter: iwakeh | Owner: metrics-team Type: enhancement | Status: needs_review Priority: Medium | Milestone: metrics-lib 2.1.0 Component: Metrics/metrics-lib | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: ---------------------------------+-----------------------------------
Comment (by karsten): Replying to [comment:20 iwakeh]: > Replying to [comment:19 karsten]: > > That's quite a few commits there, more than I can handle in a single chunk. But let me start going through them and put reviews here as I finish them. > > Yes, thanks for starting! > > > > > e0c5774 and e224680 look good. Already merged to master. > > > > Some suggestions for 77b143d: Fixes look good, squashed and merged to master. > > d687f44 looks good. Merged to master. > > I didn't finish my review of 76ae1e7, but here's some early feedback: Fixes so far look good, though I might have more thoughts on the compression part. I assumed that you wouldn't work on this branch without new input, so I went ahead and squashed the fixup commits and pushed everything to [https://gitweb.torproject.org/user/karsten/metrics- lib.git/log/?h=task-22983-3 my task-22983-3 branch] which I'll refer to from now on. Stay tuned! :) -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22983#comment:21> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs