#24914: Maybe make relay_digest_matches() not use tor_malloc()
--------------------------+------------------------------------
Reporter: dgoulet | Owner: nickm
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-relay | Actual Points:
Parent ID: | Points:
Reviewer: dgoulet | Sponsor:
--------------------------+------------------------------------
Comment (by Hello71):
also, this is the only non-test caller of crypto_digest_assign, so it
seems that we could obsolete that.
also, I'm suspicious of the memset(0). I don't totally understand, but
either this is security-critical, and we should use memwipe, or it isn't,
and don't bother zeroing it at all. I suspect gcc will optimize this
memset out anyways.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24914#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
