#25260: Merge mozbuild files into tor-launcher.git ---------------------------------------+----------------------- Reporter: sysrqb | Owner: brade Type: enhancement | Status: new Priority: Medium | Milestone: Component: Applications/Tor Launcher | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: #24856 | Points: Reviewer: | Sponsor: ---------------------------------------+-----------------------
Comment (by sysrqb): Replying to [comment:7 cypherpunks]: > Replying to [comment:6 sysrqb]: > > I dug a little deeper on this, and I build the patch from mozilla- central. It seems some changes were introduced since ESR52. 1) At build time all system addons are added into a file, > IDs of add-ons Yes > > and that file is checked at application startup[0], so we won't be able to simply copy the extension into browser/features/ post-build, > That's the goal [0] was created for. > > we'll need to modify this file too [1]. > It's auto-generated, no? Yes https://dxr.mozilla.org/mozilla-central/source/browser/app/Makefile.in#110 > > This is the situation on desktop. On mobile, I don't see where this file is created, so right now I think "features" are broken on mobile. I'll dig into this some more. > If you add Tb and Tl to "features", they'll become part of firefox build, no post-build modifications are required. > > [0] https://bugzilla.mozilla.org/show_bug.cgi?id=1348981 > > [1] obj-*/dist/bin/browser/chrome/browser/content/browser/built_in_addons.json > > [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1277920 > Generally, as Tb and Tl don't require updates, the better way to integrate them is mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1212059#c5 Adding the torlauncher extension into the omni.ja remains an option. However, considering I haven't found where the builtin-addon manifest is created during the mobile build process, I'm not sure system addons actually work on Android. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25260#comment:8> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs