#27385: https://snowflake.torproject.org/embed is confusing -------------------------------------------------+------------------------- Reporter: cypherpunks3 | Owner: arlolra Type: defect | Status: | needs_revision Priority: High | Milestone: Component: Circumvention/Snowflake | Version: Severity: Major | Resolution: Keywords: snowflake, ux-team, anti- | Actual Points: censorship-roadmap-july | Parent ID: | Points: Reviewer: cohosh | Sponsor: | Sponsor28-must -------------------------------------------------+-------------------------
Comment (by arlolra): > Smaller commits in the future would be easier to review for changes like this where it's hard to piece together which code was just moved around and where the logic changed. Sorry, I was working on this on the last day of the meeting and just pushed what I had since it wasn't clear when I'd be able to get back to it. > When I run it manually it works, but when I ran npm run webext to build it, the files didn't copy and it fails with the error Where are getting this error? I'm not able to reproduce it. > A few comments on the refactoring: Added another commit to the branch to address this, https://github.com/keroserene/snowflake/commit/f9c515cbdd302097245fd85231dc34c06d234802 I left `UI.prototype.active = false;` where it was since it's used in both the badge and webextension. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27385#comment:22> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list [email protected] https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
