#27385: https://snowflake.torproject.org/embed is confusing -------------------------------------------------+------------------------- Reporter: cypherpunks3 | Owner: arlolra Type: defect | Status: | needs_revision Priority: High | Milestone: Component: Circumvention/Snowflake | Version: Severity: Major | Resolution: Keywords: snowflake, ux-team, anti- | Actual Points: censorship-roadmap-july | Parent ID: | Points: Reviewer: cohosh | Sponsor: | Sponsor28-must -------------------------------------------------+-------------------------
Comment (by cohosh): Replying to [comment:22 arlolra]: > > When I run it manually it works, but when I ran npm run webext to build it, the files didn't copy and it fails with the error > > Where are getting this error? I'm not able to reproduce it. If I clean the `webext` directory to remove all nontracked files, and then run `npm run webext`, the `embed.css` and `embed.html` files don't copy over... is this the right way to build the webextenson? It's possible this is just a problem for me locally. I'm using npm version '6.9.0' Also, maybe not as a part of these changes though, we should probably update the README with insructions to build the webextension > > > A few comments on the refactoring: > > Added another commit to the branch to address this, > https://github.com/keroserene/snowflake/commit/f9c515cbdd302097245fd85231dc34c06d234802 > > I left `UI.prototype.active = false;` where it was since it's used in both the badge and webextension. Cool, looks good to me! -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27385#comment:23> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list [email protected] https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
