#33626: Add TBB project for GeckoView
-------------------------------------------------+-------------------------
Reporter: sisbell | Owner: gk
Type: task | Status:
| needs_review
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, tbb-rbm, | Actual Points:
TorBrowserTeam202005R, GeorgKoppen202005 |
Parent ID: #33184 | Points:
Reviewer: sysrqb | Sponsor:
| Sponsor58-must
-------------------------------------------------+-------------------------
Changes (by gk):
* keywords: tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
=> tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
* status: needs_revision => needs_review
Comment:
Replying to [comment:18 boklm]:
> In projects/firefox/build:
> {{{
> +# We need to have the get-moz-build-date script available in the
container
> +# but we can't include it via input_files as it is a script shared
between
> +# projects.
> +cat > get-moz-build-date << EOF
> + [% INCLUDE get-moz-build-date %]
> +EOF
> +
> }}}
> I think the `INCLUDE` line should not be indented, as it's adding a
space at the beginning of the file. Although it still works as we run the
script with `perl $rootdir/get-moz-build-date` and don't use the shebang
line.
Good catch. I pushed a fixup commit to my `bug_33626_v10` branch and
rebased everything onto `master`. I picked `fenix_toolchain4` as the
toolchain branch, so that `bug_33626_v11` contains the latest toolchain
fixes, too. `bug_33626_v11` (https://gitweb.torproject.org/user/gk/tor-
browser-
build.git/commit/?h=bug_33626_v11&id=a0dabf00712fbfc4d000136d19be5280cce9b82a)
is up for further review now (again with a follow-up commit not for review
to make everything buildable easily).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33626#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
