#30586: requirements are not included in setup.py
 Reporter:  irl                        |          Owner:  phw
     Type:  defect                     |         Status:  merge_ready
 Priority:  Medium                     |      Milestone:
Component:  Metrics/Onionperf          |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.45
Parent ID:  #33321                     |         Points:  0.5
 Reviewer:                             |        Sponsor:  Sponsor59-must

Comment (by phw):

 Replying to [comment:13 acute]:
 > Replying to [comment:10 karsten]:
 > > Thanks for these patches! And thanks for copying metrics-team; I had
 not seen the earlier updates (oh, Trac...).
 > >
 > > So, I tried out this branch without installing all dependencies via
 `sudo apt install python3-*`, and it starts downloading packages via
 `pip`. In our Java projects we have always avoided using package managers
 and only relied on packages provided by the system. We would give up this
 principle here, but are we sure we want to do that? How are we doing this
 in other Python projects at Tor?
 > I was wondering whether there is a distinction here that we need to make
 - how do {researchers, developers} install and use onionperf on their
 machines vs how we deploy onionperf in Tor.
 That's a good point. For third parties, installation should be quick,
 easy, and work the way it does for other Python tools. For ourselves, we
 do whatever makes the most sense for us – and that doesn't have to be
 documented in the README.md.

 On an unrelated note: I added a commit to my patch set that adds the
 pandas and seaborn requirement:

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30586#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
tor-bugs mailing list

Reply via email to