Daniel Rall <[EMAIL PROTECTED]> writes:

> [EMAIL PROTECTED] writes:
> 
> >   Log:
> >   make WEB_SITE_DTD public
> >   
> >   Revision  Changes    Path
> >   1.6       +2 -2      
> > db-torque/src/generator/src/java/org/apache/torque/engine/database/transform/DTDResolver.java
> >   
> >   Index: DTDResolver.java
> >   ===================================================================
> >   RCS file: 
> > /home/cvs/db-torque/src/generator/src/java/org/apache/torque/engine/database/transform/DTDResolver.java,v
> >   retrieving revision 1.5
> >   retrieving revision 1.6
> >   diff -u -r1.5 -r1.6
> >   --- DTDResolver.java      20 Jun 2003 18:08:43 -0000      1.5
> >   +++ DTDResolver.java      29 Jun 2003 13:38:36 -0000      1.6
> >   @@ -75,7 +75,7 @@
> >    public class DTDResolver implements EntityResolver
> >    {
> >        /** Where the DTD is located on the web. */
> >   -    private static final String WEB_SITE_DTD
> >   +    public static final String WEB_SITE_DTD
> >                = "http://db.apache.org/torque/dtd/database_3_1.dtd";;
> >    
> >        /** InputSource for <code>database.dtd</code>. */
> 
> Why did this need to be made public?

I see...you used it in TorqueJDBCTransformTask.java, which is not in
the same package (so protected/package-private scoping wouldn't have
worked either).

I find a note about why changes happened (e.g. what's now using a
newly exposed feature) extremely helpful when reading commit log
messages.
-- 

Daniel Rall

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to