[cc-ing thg-devel list]

Hi Germán

Thanks. This looks straightforward. As you've said, your going to fix
the sort order (citing this for the list's benefit):

> Just I need to set the order of the menu, because it is
> not shown as it was created, but alphabetically according to the
> internal name.

> It is just a matter of name it HgNautilus::10commit, ... ,
> HgNautilus::99about and son on; more or less in the same way it
> works /etc/initrd.

Once this is done, I suggest two things:

a) Try to find a way to detect if your submenu fix to Nautilus is
installed. Then, when it isn't, don't use submenus. This means you'll
likely want to revert to building the menu into an `items` list again
first, and then optionally use that list to populate the top-level
"Mercurial" item. This should then go as a first patch to the
thg-devel list.

b) TortoiseSvn allows one to configure which items should go into the
main menu, and which should be nested in a submenu. I like this
concept. I suggest we do it too. This would lead to a new menu entry
to configure the menu itself. If you think this is reasonable, I
suggest you implement it in a second patch that is based on the one
above.

Cheers,
-parren


On Sat, Jul 12, 2008 at 8:53 PM, Germán Póo-Caamaño <[EMAIL PROTECTED]> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://gsoc.review-board.org/r/41/
> -----------------------------------------------------------
>
> Review request for Tortoise-HG.
>
>
> Summary
> -------
>
> nautilus: move menus to submenus.
>
>
> Diffs
> -----
>
>  contrib/nautilus-thg.py
>
> Diff: http://gsoc.review-board.org/r/41/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Germán
>
>

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Tortoisehg-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to