On Fri, May 1, 2009 at 6:33 AM, Simon Heimberg <[email protected]> wrote: > Nautilus asks the state of a file when it has changed on disk. Is this > the same for windows? If it is, then we do not need to call shell_notify > when a file has changed. This would mean that the following is > unnecessary: > hggtk/changeset.py: shlib.shell_notify([self.curfile]) > hggtk/hgignore.py: shlib.shell_notify([self.ignorefile]) > > And what is the purpose of calling shell_notify on repo.root? > hggtk/update.py: shlib.shell_notify([self.root]) > hggtk/recovery.py: shlib.shell_notify([self.root]) > hggtk/merge.py (2x): shlib.shell_notify([self.root])
It's a good question. At lot of this was probably from confusion on my part. I think the shell_notify is only necessary when the file's state has changed without the file being modified. Committing converts file states from AM to C without touching them, so a notify is necessary in that case. Many of the other cases may be unnecessary. Looking at the actual documentation is probably a good idea here: http://msdn.microsoft.com/en-us/library/bb762118(VS.85).aspx Doing a notify on the repo root _and_ files inside of the root also seems redundant. -- Steve Borho ------------------------------------------------------------------------------ Register Now & Save for Velocity, the Web Performance & Operations Conference from O'Reilly Media. Velocity features a full day of expert-led, hands-on workshops and two days of sessions from industry leaders in dedicated Performance & Operations tracks. Use code vel09scf and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf _______________________________________________ Tortoisehg-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
