On 27.03.2010 19:11, Sune Foldager wrote: > On 27-03-2010 19:06, Adrian Buehlmann wrote: > >> The important thing is the UpgradeCode value in the Product element. >> The UpgradeCode code shall and will never ever change. > > Obviously not, but this we all agree on. > >> The rest of the id's, *including component id's* is subject to change >> from one msi build to the next. > > However, there is no reason to do so except when we must, IMO. > >> There *is* some reasoning behind this. One thing is, that trying to to >> minor upgrades (in Windows Installer terms) is an art for itself, that >> needs some planning right from the beginning. > > Maybe, and we're not doing that now. But might as well avoid closing any > doors.
>> The complexity of the TortoiseHg installer is already more than enough. >> It's a wet dream to believe we might be able to do correct minor upgrade >> installs with that. > > Always strive for something better :-). It's somewhat complex now, yes, > but I've seen much worse. > >> And it's pointless anyway for such a small product (small in terms of >> number of installed Megabytes and number of files). >> >> For an office package, it might be nice. But not for TortoiseHg. Here, >> it is the complexity that hurts. > > The added complexity in this case is hardly a big show-stopper. The show stopper is, if we have to commit ourselves to have all component GUIDs the same over time. The only thing we need about component GUID's is, that the GUID's in the source code and the GUID's in the installer are the same for any specific version X. Version Y != X may have entirely different GUID's for the very same components. In that way, we can use the MSI Installer API to query the install data. See http://bitbucket.org/tortoisehg/stable/changeset/af2543f5be87/ for a start of that. In particular, we do *have* to take a different product id for every built msi. Upgrading/downgrading files won't work correctly otherwise. ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
