måndag 12 juni 2023 kl. 20:24:38 UTC+2 skrev Stefan: On Saturday, June 10, 2023 at 6:27:59 PM UTC+2 [email protected] wrote:
I can reproduce this by: * deleting %appdata%\TortoiseSVN\logcache * doing Show log *and clicking a few different revisions* * Settings, Log Caching, Cached Repositories now show 4 items for the repository * repeating steps 2 and 3 seems to add 4 items to the list per iteration I still can't reproduce this. I can reproduce this only with a nightly build (I can even load the EXE in Visual Studio, add the PDBs and debug from there). No luck reproducing with my own build. Also, I can't see why clicking on revisions in the log dialog would ADD something to the cache. I also don't see where this would even touch the cache? That was a red herring, sorry. It is enough to just show the log. Another thing: The CRepositoryInfo::CData::Add() method is only called from code where a CRepositoryInfo::CData::Lookup() is called before. So it should not be possible to add entries that already exist. I'm out of ideas.... I believe the additional entries in the log cache are added from for example CRepositoryInfo::GetRepositoryRootAndUUID. It seems like CRepositoryInfo::CData::Lookup() fail to find the existing entries. I have a feeling something goes bad in TFullIndex::const_iterator iter = fullIndex.find(std::make_pair(uuid, root)). I can't really find any In the nightly builds, Visual Studio claim that fullIndex is "optimized away" so I can't really see that it contains, therefor making it difficult to debug further. I've tried to switch the nightly builds to use the debug target in r29586, hoping to see more debugging info in the next nightly build. /Daniel -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/614f9958-ba16-4a9a-9eff-5369e1739cf9n%40googlegroups.com.
