Brendan Matthew Roberts pisze: > Further: i have changed all for-each loops (unsupported in midp) found in the > netlib directory and have replaced them with for loops. > Replaced some lists with vectors, in all tried cases, these worked > Removed annotations > Some generics are left in because it breaks things further, discussion and > research as to how to fix these will be needed
Yeah, I tried to do this too and found that indeed some things might be tricky. But don't remember which ones :) I have some minor comments to the diffs: > - public static <V extends Visitor> Connection<V> > - makeConnection(FrameDecoder<V> frameDecoder, String serverUri, > V asyncVisitor) > + //public static <V extends Visitor> Connection<V> > + public static Connection > + //makeConnection(FrameDecoder<V> frameDecoder, String > serverUri, V asyncVisitor) > + makeConnection(FrameDecoder frameDecoder, String serverUri, > Visitor asyncVisitor) I think it's better to just remove things instead of commenting them. That's one of the things that a good VCS teaches :) The code is still in the repository if you need it, and there's much less clutter. And could we please keep the indent style consistent? I know some people hate tabs and stuff, but I hope that even for them the all-tabs style is better than mixed tabs/spaces. Thanks :) -- KS "To an engineer, everyone looks like a chimp" - Dilbert
signature.asc
Description: OpenPGP digital signature
_______________________________________________ tp-devel mailing list [email protected] http://www.thousandparsec.net/tp/mailman.php/listinfo/tp-devel
