On Tue, Aug 30, 2016 at 12:50:13AM -0400, Nayna Jain wrote: > Open methods for eventlog ascii and binary bios measurements file > operations are very similar. This patch refactors the code into > single open() call by passing seq_operations as i_node->private data. > > Suggested-by: Jason Gunthorpe <[email protected]> > Signed-off-by: Nayna Jain <[email protected]>
Looks basically fine, with Jarkko's comment addressed. I recommend using clang-format when working with the kernel, it makes everything easy. Reviewed-by: Jason Gunthorpe <[email protected]> Jason ------------------------------------------------------------------------------ _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
