Thanks Jason for review. I will address your comments in my next version of patches.
I also have some thoughts on one of your comment.. Responding inline in respective patch. Thanks & Regards, - Nayna On 08/30/2016 10:33 PM, Jason Gunthorpe wrote: > On Tue, Aug 30, 2016 at 12:50:13AM -0400, Nayna Jain wrote: >> Open methods for eventlog ascii and binary bios measurements file >> operations are very similar. This patch refactors the code into >> single open() call by passing seq_operations as i_node->private data. >> >> Suggested-by: Jason Gunthorpe <jguntho...@obsidianresearch.com> >> Signed-off-by: Nayna Jain <na...@linux.vnet.ibm.com> > > Looks basically fine, with Jarkko's comment addressed. I recommend > using clang-format when working with the kernel, it makes everything > easy. > > Reviewed-by: Jason Gunthorpe <jguntho...@obsidianresearch.com> > > Jason > ------------------------------------------------------------------------------ _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
