> > On Mon, Sep 12, 2016 at 11:54:58AM +0300, Tomas Winkler wrote: > > The register TPM_CRB_CTRL_REQ_x contains bits goIdle and cmdReady for > > SW to indicate that the device can enter or should exit the idle state. > > > > The legacy ACPI-start (SMI + DMA) based devices do not support these > > bits and the idle state management is not exposed to the host SW. > > Thus, this functionality only is enabled only for a CRB start (MMIO) > > based devices. > > > > Based on Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> oringal > > patch: > > 'tpm_crb: implement power tpm crb power management' > > > > Signed-off-by: Tomas Winkler <tomas.wink...@intel.com> > > V2: do not export the functions via tpm ops > > You need to restructure this series, do not implement functions that are not > used in a patch.
It's perfectly fine to stage patches for easier review, even if it cause harmless warning. > > +static int __maybe_unused crb_go_idle(struct device *dev, struct > > +crb_priv *priv) > > .. and then don't hide the warnings with maybe_unused :( This is not hiding, the issue is that when runtime pm is not compiled and the hw bug is fixed in next gen of the hardware this function will be unused. Tomas ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
