On Mon, Sep 12, 2016 at 08:26:34PM +0000, Winkler, Tomas wrote: > > > Signed-off-by: Tomas Winkler <tomas.wink...@intel.com> > > > V2: do not export the functions via tpm ops > > > > You need to restructure this series, do not implement functions that are not > > used in a patch. > > It's perfectly fine to stage patches for easier review, even if it > cause harmless warning.
That really isn't consistent with the kernel process, please don't do it. > > > +static int __maybe_unused crb_go_idle(struct device *dev, struct > > > +crb_priv *priv) > > > > .. and then don't hide the warnings with maybe_unused :( > > This is not hiding, the issue is that when runtime pm is not > compiled and the hw bug is fixed in next gen of the hardware this > function will be unused. Hum, that might be ok, but it might be better to wrapper the functions in the runtime pm ifdef Jason ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
