On Mon, Nov 21, 2016 at 10:32:44PM +0200, Jarkko Sakkinen wrote:
> On Mon, Nov 21, 2016 at 10:55:20AM -0700, Jason Gunthorpe wrote:
> > On Sun, Nov 20, 2016 at 12:14:51PM +0000, Jarkko Sakkinen wrote:
> > > I was able to apply the patch after manually editing the mbox file.
> > > Not nice. It'd be better to send these things with git-send-email
> > > to simplify the mgmt (like getting them into patchwork for starters)
> > > especially in a situation that is bit chaotic to begin with :-/
> > 
> > It is in patchwork just fine:
> > 
> > https://patchwork.kernel.org/patch/9438323/
> > 
> > git am is unfortunately much more limited than patchwork, but you can
> > apply right out of patchwork.
> > 
> > You forgot to add your signed-off-by though.
> > 
> > And this one fixes the sysfs problem
> > 
> > https://patchwork.kernel.org/patch/9438331/
> > 
> > Here is a commit message:
> > 
> > tpm: Do not call tpm_chip_unregister if register has not succeeded
> > 
> > This is no longer allowed, vtpm was relying on the check inside the
> > tpm core which was removed. Fixes an oops during error unwind.
> > 
> > Fixes: a8ed92219a04 ("tpm: Get rid of TPM_CHIP_FLAG_REGISTERED")
> > Signed-off-by: Jason Gunthorpe <jguntho...@obsidianresearch.com>
> > Tested-by: Stefan Berger <stef...@linux.vnet.ibm.com>
> > 
> > That just leaves the ACPI thing..
> 
> I like the original commit message more. It documents the change.

I added to the commits reviewed-by's and signed-off-by's as I agree on
the correctness of the changes. I'll do more formal testing before
adding testd-by...

/Jarkko

------------------------------------------------------------------------------
_______________________________________________
tpmdd-devel mailing list
tpmdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel

Reply via email to